Skip to content

Fix custom decision API URL handling for self-hosted compatibility #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chadiii wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

Fix custom decision API URL handling for self-hosted compatibility #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e894102
Fix custom decision API URL handling for self-hosted compatibility
Chadiii Nov 25, 2025
6c85516
fix tailing
Chadiii Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion flagship/dist-deno/src/decision/DecisionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,11 @@ export abstract class DecisionManager implements IDecisionManager {
visitor_consent: visitor.hasConsented
};

const url = `${this.config.decisionApiUrl || BASE_API_URL}${this.config.envId}${URL_CAMPAIGNS}?${EXPOSE_ALL_KEYS}=true&extras[]=accountSettings`;
// When using custom decisionApiUrl, assume it already includes the full path (e.g., /v2/campaigns)
// When using default BASE_API_URL, include envId in path for cloud compatibility
const url = this.config.decisionApiUrl
? `${this.config.decisionApiUrl}${URL_CAMPAIGNS}?${EXPOSE_ALL_KEYS}=true&extras[]=accountSettings`
: `${BASE_API_URL}${this.config.envId}${URL_CAMPAIGNS}?${EXPOSE_ALL_KEYS}=true&extras[]=accountSettings`;
const now = Date.now();

try {
Expand Down
6 changes: 5 additions & 1 deletion flagship/src/decision/DecisionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,11 @@ export abstract class DecisionManager implements IDecisionManager {
visitor_consent: visitor.hasConsented
};

const url = `${this.config.decisionApiUrl || BASE_API_URL}${this.config.envId}${URL_CAMPAIGNS}?${EXPOSE_ALL_KEYS}=true&extras[]=accountSettings`;
// When using custom decisionApiUrl, assume it already includes the full path (e.g., /v2/campaigns)
// When using default BASE_API_URL, include envId in path for cloud compatibility
const url = this.config.decisionApiUrl
? `${this.config.decisionApiUrl}${URL_CAMPAIGNS}?${EXPOSE_ALL_KEYS}=true&extras[]=accountSettings`
: `${BASE_API_URL}${this.config.envId}${URL_CAMPAIGNS}?${EXPOSE_ALL_KEYS}=true&extras[]=accountSettings`;
const now = Date.now();

try {
Expand Down
Loading