Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3566: Remove handling of problematic characters and add unit test #3645

Merged
merged 4 commits into from
Mar 25, 2025
Merged

GH-3566: Remove handling of problematic characters and add unit test #3645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6687be1
GH-3566: Remove handling of problematic characters and add unit test
alanakbik Mar 18, 2025
929e66a
Merge branch 'master' into GH-3566-character-removal
alanakbik Mar 22, 2025
147ec63
GH-3566: Adapt unit tests for handling of problematic characters
alanakbik Mar 22, 2025
6246561
Merge branch 'master' into GH-3566-character-removal
alanakbik Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion flair/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,7 +1213,6 @@ def get_language_code(self) -> str:

@staticmethod
def _handle_problem_characters(text: str) -> str:
text = Sentence.__remove_zero_width_characters(text)
text = Sentence.__restore_windows_1252_characters(text)
return text

Expand Down
1 change: 1 addition & 0 deletions tests/embedding_test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class BaseEmbeddingsTest:
"🤟 🤟 🤟 hüllo",
"🤟hallo 🤟 🤟 🤟 🤟",
"🤟",
"Hello \u2029 my \ufe0f name is \u200c Chris \u200b Kamphuis, and I \ufeff live in \u200c the \u2028 Netherlands.",
"\uF8F9",
]

Expand Down
2 changes: 2 additions & 0 deletions tests/test_tokenize_sentence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def test_create_sentence_with_extra_whitespace():
assert sentence.get_token(4).text == "."


@pytest.mark.skip(reason="Fix these issues for StaccatoTokenizer in future PR")
def test_create_sentence_difficult_encoding():
text = "so out of the norm ❤ ️ enjoyed every moment️"
sentence = Sentence(text)
Expand Down Expand Up @@ -485,6 +486,7 @@ def test_token_positions_when_creating_word_by_word():
assert sentence.tokens[2].end_position == 13


@pytest.mark.skip(reason="New behavior no longer excludes line separators")
def test_line_separator_is_ignored():
with_separator = "Untersuchungs-\u2028ausschüsse"
without_separator = "Untersuchungs-ausschüsse"
Expand Down