Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix type of the event parameter for onTapUp() #3460

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

alpozcan
Copy link
Contributor

Description

On https://docs.flame-engine.org/latest/ towards the bottom it says void onTapUp(TapUpInfo info)

However, this causes the following error on the latest version of Flame (1.23.0):

'Player.onTapUp' ('void Function(TapUpInfo)') isn't a valid override of 'TapCallbacks.onTapUp' ('void Function(TapUpEvent)').dartinvalid_override
tap_callbacks.dart(16, 8): The member being overridden.

Changing TapUpInfo to TapUpEvent fixes it.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@spydon spydon merged commit 9e16ef0 into flame-engine:main Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants