Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename PositionComponent to PositionedComponent #3461

Closed

Conversation

alpozcan
Copy link
Contributor

Description

Positioned is the correct usage of the word. Rename PositionComponent to PositionedComponent.
Given the nature of this change, I'm not really expecting this to be merged, but in case it can be considered for v2 perhaps, here it is.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Migration instructions

Rename all occurrences of PositionComponent to PositionedComponent.

Related Issues

@alpozcan
Copy link
Contributor Author

nevermind, tests are failing and I don't want to sink more time into this.

@alpozcan alpozcan closed this Jan 27, 2025
@pcornelissen
Copy link
Contributor

You could add a transitional PositionComponent that inherits from PositionedComponent

@alpozcan alpozcan deleted the rename-position-component branch January 27, 2025 13:52
@spydon
Copy link
Member

spydon commented Jan 27, 2025

In v2 it will most likely be called TransformComponent.

PositionComponent isn't wrong grammatically either though, it refers to that it has a position, not that it is positioned. But it has a lot more transform properties than position, which is why it'll most likely change name in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants