Skip to content

Commit 1a30d52

Browse files
authored
Merge pull request #199 from flanksource/ptr-fix-with-ns
fix: handle invalid hydrate connection error
2 parents 4dcca46 + b998cd8 commit 1a30d52

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

chart/templates/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ spec:
4949
secretKeyRef:
5050
name: {{ .Values.db.secretKeyRef.name }}
5151
key: {{ .Values.db.secretKeyRef.key }}
52+
- name: NAMESPACE
53+
valueFrom: {{ .Values.namespace | default .Release.Namespace }}
5254
resources:
5355
{{- toYaml .Values.resources | nindent 12 }}
5456
{{- with .Values.extra }}

scrapers/sql/sql.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ func (s SqlScraper) Scrape(ctx *v1.ScrapeContext, configs v1.ConfigScraper) v1.S
3131
connection, err := duty.HydrateConnection(ctx, ctx.Kubernetes, db.DefaultDB(), connection, ctx.Namespace)
3232
if err != nil {
3333
results.Errorf(err, "failed to hydrate connection for %s", config.Connection)
34+
continue
3435
}
3536
db, err := dburl.Open(connection.URL)
3637
if err != nil {

0 commit comments

Comments
 (0)