fix(connection): template HTTP connection fields - #2005
Merged
Conversation
Benchstat (Other)Base: 📊 1 minor regression(s) (all within 5% threshold)
✅ 2 improvement(s)
Full benchstat output |
Benchstat (RLS)Base: 📊 2 minor regression(s) (all within 5% threshold)
✅ 5 improvement(s)
Full benchstat output |
HTTP playbook actions template the action spec, but embedded HTTP connection fields were skipped unless the nested fields carried template tags. Values such as $(.params.url) could remain unresolved and be treated as literal relative URLs during request execution. Add template tags across HTTP connection, auth, OAuth, TLS, and AWS SigV4 fields so existing struct templating renders connection configuration before use.
adityathebe
force-pushed
the
fix/http-connection-templating
branch
from
June 12, 2026 08:31
84efe19 to
e034a11
Compare
Contributor
WalkthroughThis PR adds ChangesTemplate support for credential and connection types
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@connection/http.go`:
- Line 104: The HTTPConnection struct currently inlines types.HTTPBasicAuth only
for JSON; update the struct tag for types.HTTPBasicAuth (the embedded type) to
include yaml:",inline" as well (e.g., add yaml:",inline" alongside
json:",inline") so YAML top-level auth fields map correctly; locate the
embedding of types.HTTPBasicAuth inside the HTTPConnection definition and modify
its struct tag accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 498964d5-3c2f-43da-8cf9-e97728698c79
📒 Files selected for processing (5)
connection/aws.goconnection/http.goconnection/http_test.gotypes/auth.gotypes/oauth.go
Gavel resultsGavel exited with code . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: flanksource/mission-control#3218
HTTP playbook actions can template the action itself, but embedded HTTP connection fields were skipped unless the fields also carried template tags.
This left values like
$(.params.url)unresolved, causing HTTP requests to run against literal relative URLs such as/$(.params.url).Add template tags across HTTP connection, auth, OAuth, TLS, and AWS SigV4 fields so existing playbook templating handles connection configuration correctly.
Summary by CodeRabbit