Chore. Add the target attribute to all links - #40
Closed
pangolp wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The purpose of this pull request is to add an attribute to hyperlinks so they open in other tabs. I tried to make it optional rather than mandatory, however, it required some changes that are beyond my current knowledge. I'll post the results with screenshots later.
Reviewers should focus on:
In the future, I hope to add it as optional, but I tried, and it didn't work. In fact, this is the third pull request I've opened today. I closed the first one because I thought I had the wrong branch, so I worked on master. But then, when I was able to test the code locally, I realized it was using the current branch I wanted to contribute to.
#39
#38
2025-10-08.22-11-17.mp4