feat: auto detect tee env on issuer side #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruteri
approved these changes
Feb 3, 2025
cmd/proxy-client/main.go
Outdated
| @@ -45,8 +45,8 @@ var flags []cli.Flag = []cli.Flag{ | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: "client-attestation-type", | |||
| Value: string(proxy.AttestationNone), | |||
| Usage: "type of attestation to present (" + proxy.AvailableAttestationTypes + ")", | |||
| Value: "auto", | |||
There was a problem hiding this comment.
Similar comment as on the previous one — I think none is the correct default.
MoeMahhouk
approved these changes
Feb 3, 2025
Ruteri
reviewed
Feb 5, 2025
README.md
Outdated
| @@ -39,7 +39,7 @@ Client | |||
|
|
|||
| - `--listen-addr`: address to listen on (default: "127.0.0.1:8080") | |||
| - `--target-addr`: address to proxy requests to (default: "https://localhost:80") | |||
| - `--server-attestation-type`: type of attestation to present (none, azure-tdx) (default: "azure-tdx") | |||
| - `--server-attestation-type`: type of attestation to present (none, auto, dcap-tdx, azure-tdx) (default: "none") | |||
There was a problem hiding this comment.
default is now auto for this one right?
metachris
reviewed
Feb 5, 2025
README.md
Outdated
| @@ -39,7 +39,7 @@ Client | |||
|
|
|||
| - `--listen-addr`: address to listen on (default: "127.0.0.1:8080") | |||
| - `--target-addr`: address to proxy requests to (default: "https://localhost:80") | |||
| - `--server-attestation-type`: type of attestation to present (none, azure-tdx) (default: "azure-tdx") | |||
| - `--server-attestation-type`: type of attestation to present (none, auto, dcap-tdx, azure-tdx) (default: "none") | |||
| - `--tls-certificate-path`: Path to certificate (PEM file) to present. Only valid for --server-attestation-type=none and with `--tls-private-key-path`. | |||
| - `--tls-private-key-path`: Path to private key file for the certificate (PEM). Only valid with --tls-certificate-path. | |||
| - `--client-attestation-type`: type of attestation to expect and verify (none, azure-tdx) (default: "none") | |||
There was a problem hiding this comment.
dcap missing in this line?
metachris
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.