feat: auto handle attestation type on the validator side #33
+50
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnerdman
force-pushed
the
auto_detect_tee_env_rev_3
branch
from
566efd9 to
0cae959
Compare
metachris
reviewed
Feb 5, 2025
proxy/atls_config.go
Outdated
|
|
||
| // Create a MultiValidator for each attestation type | ||
| var validators []atls.Validator | ||
| for _, typeValidators := range validatorsByType { |
Ruteri
reviewed
Feb 5, 2025
| @@ -25,19 +25,14 @@ var flags []cli.Flag = []cli.Flag{ | |||
| Value: "https://localhost:80", | |||
| Usage: "address to proxy requests to", | |||
| }, | |||
| &cli.StringFlag{ | |||
There was a problem hiding this comment.
I'm a bit worried that this change is a breaking one without it being necessary really — we can safely ignore this flag and the behavior should be as expected.
Either we would have to release this as v0.2.0 to note the breaking change, or we could simply mark this flag as deprecated and ignored — I'd suggest the latter. We would then remove the flag as a part of v0.2.0 once it (inevitably) happens in the near future.
Same comment on the other removed flag.
Ruteri
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.