Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing early returns #35

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Adds missing early returns #35

merged 2 commits into from
Feb 20, 2025

Conversation

Ruteri
Copy link
Collaborator

@Ruteri Ruteri commented Feb 20, 2025

Adds missing early returns on unexpected measurements headers.
Thankfully this is not something that can be exploited, as:

  • If a correct attestation is exchanged, the headers will correctly be overwritten
  • If client attestation is expected but not present, as in builder-hub configuration, the request is dropped elsewhere (reproduced)
  • the only problematic case is when no client attestation is expected, but then — the headers are not expected either

Will be adding follow-up regression tests.

@MoeMahhouk
Copy link
Contributor

good catch

@Ruteri Ruteri merged commit 7947875 into main Feb 20, 2025
2 checks passed
@Ruteri Ruteri deleted the return-after-http-error branch February 20, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants