Skip to content

Add flashtestations builder transaction trait to payload builder #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add flashtestations builder transaction trait to payload builder #177

wants to merge 12 commits into from
+1,713 −615

Conversation

avalonche
Copy link
Contributor

@avalonche avalonche commented Jun 25, 2025 •
edited
Loading

📝 Summary

  • Various refactors of flashtestations service
  • Refactor of payload builder end of block transaction to accept a trait

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Base automatically changed from flashtestations-funding-key to main June 25, 2025 21:08
@avalonche avalonche force-pushed the flashtestations-builder-tx branch from 499aea1 to b2719f9 Compare June 25, 2025 22:44
@avalonche avalonche marked this pull request as ready for review June 26, 2025 15:52
@avalonche avalonche force-pushed the flashtestations-builder-tx branch 2 times, most recently from 58bac59 to 107c3cd Compare July 1, 2025 07:23
@avalonche avalonche mentioned this pull request Jul 1, 2025
Open
Ruteri
Ruteri reviewed Jul 2, 2025
View reviewed changes
crates/op-rbuilder/src/flashtestations/builder_tx.rs

/// Computes the block content hash according to the formula:
/// keccak256(abi.encode(parentHash, blockNumber, timestamp, transactionHashes))
fn compute_block_content_hash(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to link https://github.com/flashbots/rollup-boost/blob/main/specs/flashtestations.md#block-building-process

@avalonche avalonche force-pushed the flashtestations-builder-tx branch from 079db2f to 37ad854 Compare July 2, 2025 16:02
@avalonche avalonche force-pushed the flashtestations-builder-tx branch 5 times, most recently from e67896f to c1bac40 Compare July 17, 2025 15:20
@avalonche avalonche force-pushed the flashtestations-builder-tx branch 3 times, most recently from b2a8177 to 3686edc Compare July 22, 2025 06:25
@avalonche avalonche force-pushed the flashtestations-builder-tx branch from 3686edc to 8a4d304 Compare July 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruteri Ruteri Ruteri left review comments

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

@SozinM SozinM Awaiting requested review from SozinM SozinM is a code owner

@karim-agha karim-agha Awaiting requested review from karim-agha karim-agha is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avalonche @Ruteri