New witness calculation and DA config #431
Closed
+244
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
approved these changes
Feb 17, 2025
ryanschneider
force-pushed
the
reth-1.2.0
branch
from
bb35cba to
63dd9b6
Compare
SozinM
force-pushed
the
msozin/op-rbuilder/changes-into-1.2.0
branch
from
38d29fd to
b26aec5
Compare
|
Rebased |
ryanschneider
force-pushed
the
reth-1.2.0
branch
from
63dd9b6 to
bb35cba
Compare
## 📝 Summary Add builder names to dry run relay. ## 💡 Motivation and Context <!--- (Optional) Why is this change required? What problem does it solve? Remove this section if not applicable. --> --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
## 📝 Summary * makes rbuilder last target -> build by default * fix docker ARGs ## 💡 Motivation and Context <!--- (Optional) Why is this change required? What problem does it solve? Remove this section if not applicable. --> --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
Add DA config to builder Account for builder_tx in block_da_size.
SozinM
force-pushed
the
msozin/op-rbuilder/changes-into-1.2.0
branch
from
b26aec5 to
dcd3364
Compare
|
new one #436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New witness calculation algo.
DA config.
Reserve space for builder_tx in block_da_size.
Note:
If
da_config.max_da_tx_sizeis too small,executefunction of OpBuilder will panic, because it's improssible to insert builder transaction.estimate_builder_tx_da_sizemay be a little bit heavy, maybe we could precompute tx size for builder_tx and reuse it📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test