Remove task trait #439
Open
Remove task trait #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have an error with lifetime of &self with executor.spawn_blocking
SozinM
force-pushed
the
msozin/op-rbuilder/remove-task-trait
branch
from
ffdb8b0 to
3ba33f1
Compare
SozinM
force-pushed
the
msozin/op-rbuilder/remove-task-trait
branch
from
aa222d2 to
49682b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Could be merged after #436
Closes #428
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test