Skip to content

Move ExecutionInfo and ExecutedPayload into different crate #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SozinM
Copy link
Contributor

@SozinM SozinM commented Feb 24, 2025

πŸ“ Summary

Moving out types that used in both builders to simplify it.
Goes after #443

Clear PR with changes: NethermindEth#5

πŸ’‘ Motivation and Context


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@SozinM SozinM force-pushed the msozin/op-rbuilder/execution-crate branch from 4ee7d98 to 9ed4f94 Compare February 24, 2025 08:55
@SozinM SozinM mentioned this pull request Feb 24, 2025
3 tasks
Copy link
Contributor

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to contain changes from #443?

@avalonche
Copy link
Contributor

this looks fine to me, just wondering about maintenance - since we are moving reth types out of the file, what would the process be like for comparing the diff between rbuilder and reth to ensure reth changes are upstreamed correctly?

@SozinM
Copy link
Contributor Author

SozinM commented Feb 25, 2025

@avalonche Good question.
Problems i see in the current code:

  1. We have type duplicates
  2. Some types have different order from reth builder.rs

How i see process of rebasing:
We open diff between reth , for example 1.1.5 <> 1.2.0
We go trough all changes in payload/src/builder.rs
And if we see changes we need to take we put them in relevant files

@dvush dvush deleted the branch flashbots:reth-1.2.0 February 26, 2025 17:08
@dvush dvush closed this Feb 26, 2025
@SozinM SozinM deleted the msozin/op-rbuilder/execution-crate branch March 11, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants