Don't ignore --build-shell option when configuration fails
#625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--build-shell is supposed to help in debbuging problems for modules, that may be a failure to build, to configure, etc. So it doesn't make much sense that if the configuration step fails we ignore the --build-shell option, which the developer probably use it to debug that configure problem. Fixes flatpak#479
swick
reviewed
Sep 2, 2025
| g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, "module %s: Invalid buildsystem: \"%s\"", | ||
| self->name, self->buildsystem); | ||
| return FALSE; | ||
| return run_shell ? shell (app_dir, self->name, context, source_dir, build_dir_relative, build_args, env, error) : FALSE; |
There was a problem hiding this comment.
This is passing in a non-empty error, so that won't work.
|
#508 seems like the better fix to me than this.
I'm not sure why opening the shell first would be a problem instead of ignoring errors in build-shell. If you are debugging a build which is broken in the configure step, you likely want to open a shell first and then manually run the configure commands etc. to debug it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--build-shellis supposed to help in debbuging problems for modules, that may be a failure to build, to configure, etc.So it doesn't make much sense that if the configuration step fails we ignore the
--build-shelloption, which the developer is probably using it to debug that same configure problem.Fixes #479