Skip to content

Revert "Upload to codecov lies in its own job" - #142

Merged
amantoux merged 1 commit into
masterfrom
revert-140-decouple_build_from_codecov
Jun 19, 2023
Merged

Revert "Upload to codecov lies in its own job"#142
amantoux merged 1 commit into
masterfrom
revert-140-decouple_build_from_codecov

Conversation

@amantoux

@amantoux amantoux commented Jun 19, 2023

Copy link
Copy Markdown
Member

Reverts #140

@amantoux
amantoux merged commit 716862d into master Jun 19, 2023
@Amir-P
Amir-P deleted the revert-140-decouple_build_from_codecov branch June 19, 2023 10:45
@Amir-P

Amir-P commented Jun 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What was the reason for reverting it? @amantoux

@amantoux

amantoux commented Jun 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

What was the reason for reverting it? @amantoux

@Amir-P , I was about to comment this.
Actually, the decoupling isn't sending properly the cov files to Codecov, it needs more investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amantoux @Amir-P