Skip to content

Re-initialized ordered list index when no current index available #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amantoux merged 1 commit into from
Jul 22, 2025
Merged

Re-initialized ordered list index when no current index available #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/fleather/lib/src/widgets/editable_text_block.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ class EditableTextBlock extends StatelessWidget {
if (lastLevel == currentLevel) {
currentIndex = levelsIndexes[lastLevel]! + 1;
} else if (lastLevel > currentLevel) {
currentIndex = levelsIndexes[currentLevel]! + 1;
final currentLevelIndex = levelsIndexes[currentLevel];
currentIndex = currentLevelIndex == null ? 0 : currentLevelIndex + 1;
}
}

Expand Down
16 changes: 16 additions & 0 deletions packages/fleather/test/widgets/editable_text_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,22 @@ void main() {
await editor.pump();
expect(find.text('1.', findRichText: true), findsOneWidget);
});

testWidgets('multi list', (tester) async {
final delta = Delta()
..insert('numbered1')
..insert('\n', {'block': 'ol'})
..insert('bullet_with_indent')
..insert('\n', {'block': 'ul', 'indent': 1})
..insert('numbered_with_more_indent')
..insert('\n', {'block': 'ol', 'indent': 2})
..insert('numbered_with_indent')
..insert('\n', {'block': 'ol', 'indent': 1});
final editor = EditorSandBox(
tester: tester, document: ParchmentDocument.fromDelta(delta));
await editor.pump();
expect(find.text('1.', findRichText: true), findsNWidgets(3));
});
});

testWidgets('headings', (tester) async {
Expand Down