Allow the editor in read-only to tighten to the actual necessary width - #530
Merged
Conversation
amantoux
marked this pull request as draft
August 1, 2025 10:11
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 88.71% 88.93% +0.22%
==========================================
Files 63 63
Lines 10857 10876 +19
==========================================
+ Hits 9632 9673 +41
+ Misses 1225 1203 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amantoux
marked this pull request as ready for review
August 1, 2025 14:01
Amir-P
reviewed
Aug 1, 2025
Amir-P
left a comment
Member
There was a problem hiding this comment.
We really needed it! Thanks! I just have two small comments. PTAL.
Member
Author
|
@Amir-P Fixed accordingly, can you please take a look? |
amantoux
force-pushed
the
text_width_basis
branch
from
August 1, 2025 19:35
35ca562 to
f9c7a9c
Compare
amantoux
force-pushed
the
text_width_basis
branch
from
August 2, 2025 07:07
f9c7a9c to
46db52b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows editor to shrink to max content size in read-only
To acheive this, one can use a new paramter
textWidthBasisHow it renders
Before
After