[Parchment] Invalidate line node offset cache when inserting it after or before in parent node - #532
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 88.93% 88.99% +0.05%
==========================================
Files 63 63
Lines 10876 10891 +15
==========================================
+ Hits 9673 9692 +19
+ Misses 1203 1199 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amantoux
marked this pull request as draft
August 5, 2025 09:57
amantoux
changed the title
amantoux
force-pushed
the
fix/corrupted_offset_cache
branch
from
August 5, 2025 12:42
09690ba to
4789d46
Compare
amantoux
changed the title
amantoux
changed the title
amantoux
force-pushed
the
fix/corrupted_offset_cache
branch
from
August 5, 2025 12:58
4789d46 to
0c3394b
Compare
amantoux
marked this pull request as ready for review
August 5, 2025 12:59
amantoux
changed the title
Amir-P
approved these changes
Aug 8, 2025
Amir-P
left a comment
Amir-P
left a comment
Member
There was a problem hiding this comment.
Thanks for working on the fix, Alan. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #526