Skip to content

EditableBox handles body that do not compute distance to actual baseline - #550

Merged
amantoux merged 3 commits into
masterfrom
handle_insertion_of_embed_with_no_baseline
Sep 20, 2025
Merged

EditableBox handles body that do not compute distance to actual baseline#550
amantoux merged 3 commits into
masterfrom
handle_insertion_of_embed_with_no_baseline

Conversation

@amantoux

Copy link
Copy Markdown
Member

Fixes #424

@amantoux amantoux changed the title EditableBox handles body that do not compute distance to actual baseline EditableBox handles body that do not compute distance to actual baseline Sep 14, 2025
@codecov

codecov Bot commented Sep 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.24%. Comparing base (ea6767f) to head (1fc5d66).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   89.17%   89.24%   +0.06%     
==========================================
  Files          63       63              
  Lines       10984    10986       +2     
==========================================
+ Hits         9795     9804       +9     
+ Misses       1189     1182       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amantoux
amantoux requested a review from Amir-P September 14, 2025 07:58

@Amir-P Amir-P left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amantoux
amantoux force-pushed the handle_insertion_of_embed_with_no_baseline branch from a1a7fa2 to 6f48ea0 Compare September 20, 2025 08:59
@amantoux
amantoux force-pushed the handle_insertion_of_embed_with_no_baseline branch from 6f48ea0 to 1fc5d66 Compare September 20, 2025 09:23
@amantoux
amantoux merged commit 734ea5e into master Sep 20, 2025
4 checks passed
@amantoux
amantoux deleted the handle_insertion_of_embed_with_no_baseline branch September 20, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starting rich text with a divider breaks ability for rich text to expand

2 participants