Skip to content

Remove unnecessary scroll assertions - #552

Merged
amantoux merged 2 commits into
masterfrom
fix/scroll_assertions_adapted_to_scrollable_false
Sep 20, 2025
Merged

Remove unnecessary scroll assertions#552
amantoux merged 2 commits into
masterfrom
fix/scroll_assertions_adapted_to_scrollable_false

Conversation

@amantoux

Copy link
Copy Markdown
Member

No description provided.

@amantoux
amantoux requested a review from Amir-P September 20, 2025 09:00
@codecov

codecov Bot commented Sep 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.17%. Comparing base (ea6767f) to head (147f4d2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   89.17%   89.17%           
=======================================
  Files          63       63           
  Lines       10984    10985    +1     
=======================================
+ Hits         9795     9796    +1     
  Misses       1189     1189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread packages/fleather/lib/src/widgets/editor.dart Outdated
@amantoux amantoux changed the title Adapt scroll assertions to case where scrollable=false Remove scroll assertions to case where scrollable=false Sep 20, 2025
@amantoux amantoux changed the title Remove scroll assertions to case where scrollable=false Remove unnecessary scroll assertions Sep 20, 2025
@amantoux
amantoux requested a review from Amir-P September 20, 2025 09:29
@amantoux
amantoux merged commit 2338119 into master Sep 20, 2025
4 checks passed
@amantoux
amantoux deleted the fix/scroll_assertions_adapted_to_scrollable_false branch September 20, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants