Skip to content

Editor content width is the max child width - #557

Merged
amantoux merged 1 commit into
masterfrom
fix/incorrect_editor_content_width
Sep 23, 2025
Merged

Editor content width is the max child width#557
amantoux merged 1 commit into
masterfrom
fix/incorrect_editor_content_width

Conversation

@amantoux

@amantoux amantoux commented Sep 22, 2025

Copy link
Copy Markdown
Member

When used with TextWidthBasis.longestLine, the editor width would accumulate child width instead of using the children max width.

Fixes #558

@codecov

codecov Bot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (b4c4d7a) to head (3db1148).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   89.30%   89.30%           
=======================================
  Files          63       63           
  Lines       10985    10985           
=======================================
  Hits         9810     9810           
  Misses       1175     1175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amantoux
amantoux requested a review from Amir-P September 22, 2025 13:44

@Amir-P Amir-P left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amantoux
amantoux merged commit 4bb9600 into master Sep 23, 2025
4 checks passed
@amantoux
amantoux deleted the fix/incorrect_editor_content_width branch September 23, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect width of editor when using TextWidthBasis.longestLine

2 participants