Fix _showCaretOnScreen uses wrong rect to show editor on screen - #560
Merged
amantoux merged 2 commits intoSep 24, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
=======================================
Coverage 89.30% 89.30%
=======================================
Files 63 63
Lines 10985 10990 +5
=======================================
+ Hits 9810 9815 +5
Misses 1175 1175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Amir-P
deleted the
fix/show_caret_on_screen_uses_wrong_rect_to_show_editor_on_screen
branch
September 24, 2025 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #559