Skip to content

Fix crash when inserting newlines rapidly #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bilaldev05 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crash when inserting newlines rapidly #578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9344355
Fix crash when inserting newlines rapidly
bilaldev05 Mar 7, 2026
ac696ee
dart format
amantoux Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/fleather/lib/src/rendering/editable_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,15 +247,17 @@ class RenderEditableContainerBox extends RenderBox

final targetNode = node.lookup(position.offset).node;

var targetChild = firstChild;
RenderEditableBox? targetChild = firstChild;

while (targetChild != null) {
if (targetChild.node == targetNode) {
break;
return targetChild;
}
targetChild = childAfter(targetChild);
}
assert(targetChild != null, 'No child at position $position');
return targetChild!;

// Fallback: return last available child instead of crashing
return lastChild!;
}

/// Returns child of this container located at the specified local `offset`.
Expand Down
Loading