migrations assume role support #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd usage ✨ (addons/migrations): Add support for assuming IAM role for ECS permissions in migration script
|
closes #28 |
rfairburn
previously approved these changes
Apr 20, 2025
I still need to run through some test scenarios. |
maxammann
reviewed
Apr 21, 2025
| ## Important Considerations | ||
|
|
||
| * **`local-exec`:** This provisioner runs commands on the machine executing Terraform. Ensure this machine has the necessary tools (bash, AWS CLI) and network access/credentials to interact with your AWS environment. This might require specific configuration in CI/CD pipelines. | ||
| * **IAM Permissions:** The credentials used by `local-exec` (either default AWS credentials or the assumed role specified by `assume_role_arn`) require sufficient IAM permissions to manage the specified ECS services and tasks. |
There was a problem hiding this comment.
It would be great if we document some permission set to execute the migration script. Also which sources it should taget. Potentially this module could provide the role even? Given that the migrate.sh script can change and depends on certain resources.
|
Any update on this one? Even without the role creation this is really helpful already :) |
|
@edwardsb is this ready to merge? |
edwardsb
force-pushed
the
edwardsb-migration-assume-role
branch
from
30b2f53 to
2ff3063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.