Improve Blur-My-Shell compatibility

[Schneegans]

This improves the compatibility with Blur-My-Shell. The main problem was that BMS adds an additional child to the MetaWindowActors for the blurred background and RWC applies its effect to that actor instead to the actual window's content.

On X11, the results are pretty good. I think the only remaining issue is that the corners of blurred background are not rounded. But with subtle corner radii this is hardly visible:

On Wayland, there are other incompatibility issues which I haven't figured out so far. I am aware that @aunetx mentioned a fundamental incompatibly, although I do not understand why that is, because the effects are applied to different actors...

Edit: Maybe it works now on Wayland as well... see below.

[Schneegans]

I wonder: Why is the effect added directly to the Meta.WindowActor for Wayland clients and to the surface actor for X11 clients? If I add it to the surface actor in all cases, it seems that most issues are gone on Wayland as well...

I am talking about this line and this line.

[flexagoon]

I wonder: Why is the effect added directly to the Meta.WindowActor for Wayland clients and to the surface actor for X11 clients? If I add it to the surface actor in all cases, it seems that most issues are gone on Wayland as well...

I am talking about this line and this line.

I don't remember tbh, I think it was like that in the old RWC code, and when I tried to remove it, something broke.

That being said, I don't fully understand how actors and stuff work, and I trust you on this topic since the code of your Burn My Windows extension was one of my main references when writing this

[Schneegans]

Well, I do not know either why that's there 😄 I suppose it was there for a good reason... I'll just add the change, fix the linting error and then we can maybe ask the guys from the BMS issue to give this an in-depth test. Maybe somebody figures out the reason why this was there 😅

[flexagoon]

If you tested it with that code removed and it worked fine on both X11 and Wayland, then it's probably fine to remove it, it may have been a workaround for some issue in an old GNOME version

[Schneegans]

If you tested it with that code removed and it worked fine on both X11 and Wayland, then it's probably fine to remove it, it may have been a workaround for some issue in an old GNOME version

Yeah, could be. But I would be happy if someone else could test this as I am pretty sure that there are various applications which do fancy things with their windows which I will not encounter during my testing...

[momoRaza]

It seems to break when scaling to 200% (Arch Linux Gnome 47, wayland)
Screencast From 2025-02-02 18-35-04.webm

[flexagoon]

aunetx/blur-my-shell#634 (comment)

@momoRaza do I understand it correctly that there are no issues when using 200% scaling on a real machine?

[Schneegans]

I observed some issues as well when scaling is involved. A bit hard to reproduce but I think they can be resolved as the issues are gone once a window is resized, so I think we only need to trigger some callback after a window is shown. But I currently have not the time to look into it 😟

So I think this should be resolved before merging this. Maybe I find the time in the coming days but currently I am quite busy with porting all my extensions to GNOME 48... 😅

[momoRaza]

aunetx/blur-my-shell#634 (comment)

@momoRaza do I understand it correctly that there are no issues when using 200% scaling on a real machine?

yes, besides the square edges here and there, it seems to be working correctly

[momoRaza]

I observed some issues as well when scaling is involved. A bit hard to reproduce but I think they can be resolved as the issues are gone one a window is resized, so I think we only need to trigger some callback after a window is shown. But I currently have not the time to look into it 😟

So I think this should be resolved before merging this. Maybe I find the time in the coming days but currently I am quite busy with porting all my extensions to GNOME 48... 😅

Good luck with the porting, and thank you for putting in the time for making this extension.