Skip to content

Fix hashes #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: inference
Choose a base branch
from
Draft

Fix hashes #86

wants to merge 4 commits into from

Conversation

goliaro
Copy link
Contributor

@goliaro goliaro commented Jan 9, 2025 •
edited by lockshaw
Loading

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

@suranap
Test MachineView.hash
899ddea 
This exposes the collision found for 8 nodes * 4 gpus.
@suranap
Replace poor hash function with hash_combine
97ad611 
These hashes use hash<int> which is the identity function. So no
hashing occurs at all!
@suranap
Use Boost's hash_combine for 32 and 64-bit values
2a4c599 
Issue #902
@suranap
Clang format
693eb12
@lockshaw lockshaw mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hash function doesn't hash
2 participants
@goliaro @suranap