Skip to content

Conversation

srghma
Copy link

@srghma srghma commented Jul 8, 2025

No description provided.

@flip111
Copy link
Owner

flip111 commented Jul 8, 2025

Fn

The implementation for unsafe array was taken from here https://github.com/purescript/purescript-arrays/pull/182/files

JordanMartinez usually writes high quality code.

Fn functions are for interfacing with existing libraries that you don't have control over (which is not the case here) OR for extra performance gains. But you loose the ability to use currying (which is more idiomatic purescript).

I'm inclined to leave the currying ability in place unless you have very strong reasons why we should remove it. With very strong reasons i mean a project (either a real project or toy mini project) that has benchmarks for both cases so we can see the actual numbers.

purs-tidy

can you not re-format existing functions with purs-tidy please?

other changes

the other changes look good (just reading from their titles), though everything is lumped together in one PR so i can't merge things i would immediately approve of


i will review it more thoroughly after hearing your thoughts, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants