Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests/config): get test suite back into passing state #3872

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(tests/config): get test suite back into passing state #3872

merged 1 commit into from
Feb 3, 2025

Conversation

GeorgeMac
Copy link
Member

OK, initial pass to get config tests green again.

@GeorgeMac GeorgeMac requested a review from a team as a code owner February 3, 2025 16:48
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 3, 2025
@GeorgeMac GeorgeMac requested a review from markphelps February 3, 2025 16:48
markphelps
markphelps approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@GeorgeMac GeorgeMac merged commit f6f944e into v2 Feb 3, 2025
5 of 27 checks passed
@GeorgeMac GeorgeMac deleted the gm/test-fix-config branch February 3, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeMac @markphelps