Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage/fs): various fixes and base test cases #3877

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

GeorgeMac
Copy link
Member

This fixes are few things which did not work after the first pass moving eval snapshots into the existing fs/snapshot code.

There were a few missing fields on various types:

  • Description on Rollout
  • Value on Segment type Rollout
  • The eval flag was not being appended from the flag set
  • The eval snap rollout was not being append
  • The eval snapshot namespaces map was not being initialized

I added a bunch of simply baseline unit tests which surfaced all of these things and then I fixed them in this PR.

Here is what the robots said:

Improved error handling:

  • internal/storage/fs/snapshot.go: Added a check for namespace existence in the GetEvaluationDistributions function, returning an error if the namespace is not found.

Updates to test data:

@GeorgeMac GeorgeMac requested a review from a team as a code owner February 4, 2025 14:11
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Feb 4, 2025
@GeorgeMac GeorgeMac merged commit 0f4589d into v2 Feb 4, 2025
5 of 27 checks passed
@GeorgeMac GeorgeMac deleted the gm/test-fs-snapshot branch February 4, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants