Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: V2 UI rules #3882

Merged
merged 6 commits into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# version: "1.0"
log:
level: INFO
level: DEBUG

# authentication:
# required: false
Expand Down
14 changes: 10 additions & 4 deletions internal/storage/environments/fs/flipt/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,19 @@ func (f *FlagStorage) GetResource(ctx context.Context, fs environmentsfs.Filesys
continue
}

for _, f := range doc.Flags {
if f.Key == key {
payload, err := payloadFromFlag(f)
for _, ff := range doc.Flags {
if ff.Key == key {
payload, err := payloadFromFlag(ff)
if err != nil {
return nil, err
}

// TODO: remove this after ui is complete
f.logger.Debug("get flag", zap.Any("flag", payload))

return &rpcenvironments.Resource{
Namespace: namespace,
Key: f.Key,
Key: ff.Key,
Payload: payload,
}, nil
}
Expand Down Expand Up @@ -125,6 +128,9 @@ func (f *FlagStorage) PutResource(ctx context.Context, fs environmentsfs.Filesys
return err
}

// TODO: remove this after ui is complete
f.logger.Debug("put flag", zap.Any("flag", flag))

docs, idx, err := getDocsAndNamespace(ctx, fs, rs.Namespace)
if err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions ui/index.dev.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

<script type="module">
import RefreshRuntime from 'http://localhost:5173/@react-refresh';

RefreshRuntime.injectIntoGlobalHook(window);
window.$RefreshReg$ = () => {};
window.$RefreshSig$ = () => (type) => type;
Expand Down
137 changes: 99 additions & 38 deletions ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"@babel/preset-typescript": "^7.26.0",
"@playwright/test": "^1.49.1",
"@tailwindcss/forms": "^0.5.9",
"@trivago/prettier-plugin-sort-imports": "^5.2.2",
"@types/jest": "^29.5.14",
"@types/loadable__component": "^5.13.9",
"@types/node": "^18.19.71",
Expand Down
16 changes: 14 additions & 2 deletions ui/prettier.config.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
module.exports = {
plugins: ['prettier-plugin-tailwindcss'],
plugins: [
'prettier-plugin-tailwindcss',
'@trivago/prettier-plugin-sort-imports'
],
singleQuote: true,
trailingComma: 'none'
trailingComma: 'none',
importOrder: [
'^~/app/(.*)$',
'^~/components/(.*)$',
'^~/types/(.*)$',
'^~/(.*)$',
'^[./]'
],
importOrderSeparation: true,
importOrderSortSpecifiers: true
};
13 changes: 8 additions & 5 deletions ui/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
import loadable from '@loadable/component';
import formbricks from '@formbricks/js/website';
import loadable from '@loadable/component';
import { useEffect, useState } from 'react';
import { Helmet } from 'react-helmet';
import { useSelector } from 'react-redux';
import { RouterProvider, createHashRouter, redirect } from 'react-router';

import { selectCurrentNamespace } from '~/app/namespaces/namespacesApi';
import { createHashRouter, redirect, RouterProvider } from 'react-router';

import ErrorLayout from './app/ErrorLayout';
import Flag from './app/flags/Flag';
import NewFlag from './app/flags/NewFlag';
import Layout from './app/Layout';
import NotFoundLayout from './app/NotFoundLayout';
import Flag from './app/flags/Flag';
import NewFlag from './app/flags/NewFlag';
import { selectTheme } from './app/preferences/preferencesSlice';
import NewSegment from './app/segments/NewSegment';
import Segment from './app/segments/Segment';
import SessionProvider from './components/SessionProvider';
import { Theme } from './types/Preferences';
import { store } from './store';
import { Theme } from './types/Preferences';

const Flags = loadable(() => import('./app/flags/Flags'));
const Segments = loadable(() => import('./app/segments/Segments'));
const Console = loadable(() => import('./app/console/Console'));
Expand Down
1 change: 1 addition & 0 deletions ui/src/app/ErrorLayout.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Link, useNavigate, useRouteError } from 'react-router';

import logoFlag from '~/assets/logo-flag.png';

export default function ErrorLayout() {
Expand Down
18 changes: 11 additions & 7 deletions ui/src/app/Layout.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { StarIcon } from '@heroicons/react/20/solid';
import { useEffect, useState } from 'react';
import { useSelector } from 'react-redux';
import {
Expand All @@ -7,27 +8,30 @@ import {
useNavigate,
useParams
} from 'react-router';

import Banner from '~/components/Banner';
import Footer from '~/components/Footer';
import Header from '~/components/Header';
import Loading from '~/components/Loading';
import { NotificationProvider } from '~/components/NotificationProvider';
import Sidebar from '~/components/Sidebar';
import CommandDialog from '~/components/command/CommandDialog';
import ErrorNotification from '~/components/notifications/ErrorNotification';
import SuccessNotification from '~/components/notifications/SuccessNotification';
import Sidebar from '~/components/Sidebar';

import { LoadingStatus } from '~/types/Meta';

import { useSession } from '~/data/hooks/session';
import { useAppDispatch } from '~/data/hooks/store';
import { LoadingStatus } from '~/types/Meta';

import { selectCurrentEnvironment } from './environments/environmentsApi';
import { selectDismissedBanner } from './events/eventSlice';
import { fetchInfoAsync, selectInfo } from './meta/metaSlice';
import {
currentNamespaceChanged,
selectCurrentNamespace,
useListNamespacesQuery
} from './namespaces/namespacesApi';
import CommandDialog from '~/components/command/CommandDialog';
import Banner from '~/components/Banner';
import { selectDismissedBanner } from './events/eventSlice';
import { StarIcon } from '@heroicons/react/20/solid';
import { selectCurrentEnvironment } from './environments/environmentsApi';

function InnerLayout() {
const { session } = useSession();
Expand Down
Loading
Loading