fix(build): rework test suite to compile for the new environments API #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
GeorgeMac
commented
Feb 6, 2025
GeorgeMac
commented
Feb 6, 2025
markphelps
approved these changes
Feb 6, 2025
| } | ||
|
|
||
| // TODO(georgemac): wire in version ldflag | ||
| // TODO(mark): does version make sense now? |
There was a problem hiding this comment.
how do you mean does it make sense?
There was a problem hiding this comment.
Are you asking your past self, or?
There was a problem hiding this comment.
lol idk why I thought you added this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is queued up on #3880
While this doesn't get the ITs into a passing state, it gets it into a compiling state.
I ported over all the original tests we had around the Flipt cloud implementation.
I will continue working on getting them passing in a subsequent PR.
This at-least lays the foundation.