Fix #982: BUG: Ignored cache migration error at startup#1005
Open
itniuma2026 wants to merge 1 commit intofloatpane:masterfrom
Open
Fix #982: BUG: Ignored cache migration error at startup#1005itniuma2026 wants to merge 1 commit intofloatpane:masterfrom
itniuma2026 wants to merge 1 commit intofloatpane:masterfrom
Conversation
Replace the silently ignored cache migration error with a logged warning so users are informed when migration fails. Fixes floatpane#982
floatpanebot
requested changes
Apr 25, 2026
Member
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @itniuma2026! Please fix the following issues with your PR:
- Title: Does not follow conventional commits (e.g.,
feat: added something,fix(core): resolved crash). - Title: Is too long (55 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
Author
|
Thanks for the feedback! The issues raised are about the PR title and body formatting, not the code itself — so no code changes are needed here. I'll update the PR title to follow conventional commits and keep it under 40 characters, and add the required |
Member
|
@itniuma2026 please, fix the issues with the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the silently ignored cache migration error with a logged warning so users are informed when migration fails.
Approach
In main.go around line 3562, replace
_ = config.MigrateCacheFiles()with a proper error check that logs a warning message when the migration returns an error. This is a minimal change: capture the error return value and, if non-nil, log a warning using the project's existing logging mechanism (e.g.,log.Warnorlog.Printf). No other files need modification.Files Changed
main.goRelated Issue
Fixes #982
Testing
Verified the change manually. Let me know if you'd like any additional tests or adjustments.