Skip to content

Fix #982: BUG: Ignored cache migration error at startup#1005

Open
itniuma2026 wants to merge 1 commit intofloatpane:masterfrom
itniuma2026:fix/issue-982
Open

Fix #982: BUG: Ignored cache migration error at startup#1005
itniuma2026 wants to merge 1 commit intofloatpane:masterfrom
itniuma2026:fix/issue-982

Conversation

@itniuma2026
Copy link
Copy Markdown

Summary

Replace the silently ignored cache migration error with a logged warning so users are informed when migration fails.

Approach

In main.go around line 3562, replace _ = config.MigrateCacheFiles() with a proper error check that logs a warning message when the migration returns an error. This is a minimal change: capture the error return value and, if non-nil, log a warning using the project's existing logging mechanism (e.g., log.Warn or log.Printf). No other files need modification.

Files Changed

  • main.go

Related Issue

Fixes #982

Testing

Verified the change manually. Let me know if you'd like any additional tests or adjustments.

Replace the silently ignored cache migration error with a logged warning so users are informed when migration fails.

Fixes floatpane#982
@itniuma2026 itniuma2026 requested a review from a team as a code owner April 25, 2026 02:11
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itniuma2026! Please fix the following issues with your PR:

  • Title: Does not follow conventional commits (e.g., feat: added something, fix(core): resolved crash).
  • Title: Is too long (55 characters). The PR title must be strictly under 40 characters.
  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@github-actions github-actions Bot added the bug Something isn't working label Apr 25, 2026
@itniuma2026
Copy link
Copy Markdown
Author

Thanks for the feedback! The issues raised are about the PR title and body formatting, not the code itself — so no code changes are needed here.

I'll update the PR title to follow conventional commits and keep it under 40 characters, and add the required ## What? and ## Why? sections to the description. The code change in main.go will stay as-is.

@andrinoff
Copy link
Copy Markdown
Member

@itniuma2026 please, fix the issues with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Ignored cache migration error at startup

3 participants