Skip to content

chore: use strings.Builder in yubikey #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrinoff merged 1 commit into from
Apr 27, 2026
+11 −10
Merged

chore: use strings.Builder in yubikey #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions pgp/yubikey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"io"
"math/big"
"os"
"strings"
"time"

pgpcrypto "github.com/ProtonMail/go-crypto/openpgp"
Expand Down Expand Up @@ -478,29 +479,29 @@ func GetYubiKeyInfo() (string, error) {
}
defer card.Close()

var info string
var info strings.Builder

aid := card.ApplicationRelated.AID
info += fmt.Sprintf("Manufacturer: %s\n", aid.Manufacturer)
info += fmt.Sprintf("Serial: %X\n", aid.Serial)
info += fmt.Sprintf("Version: %s\n", aid.Version)
info.WriteString(fmt.Sprintf("Manufacturer: %s\n", aid.Manufacturer))
info.WriteString(fmt.Sprintf("Serial: %X\n", aid.Serial))
info.WriteString(fmt.Sprintf("Version: %s\n", aid.Version))

ch, err := card.GetCardholder()
if err == nil && ch.Name != "" {
info += fmt.Sprintf("Cardholder: %s\n", ch.Name)
info.WriteString(fmt.Sprintf("Cardholder: %s\n", ch.Name))
}

if keys := card.ApplicationRelated.Keys; keys != nil {
if ki, ok := keys[openpgp.KeySign]; ok {
info += fmt.Sprintf("Sign Key: %s", ki.AlgAttrs)
info.WriteString(fmt.Sprintf("Sign Key: %s", ki.AlgAttrs))
if ki.Status == openpgp.KeyGenerated {
info += " (generated)"
info.WriteString(" (generated)")
} else if ki.Status == openpgp.KeyImported {
info += " (imported)"
info.WriteString(" (imported)")
}
info += "\n"
info.WriteString("\n")
}
}

return info, nil
return info.String(), nil
}
Loading