chore(daemon): named timeout constants#1027
Merged
andrinoff merged 1 commit intofloatpane:masterfrom Apr 27, 2026
Merged
Conversation
Replaces ad-hoc 60s/30s literals across daemon/handler.go with fetchTimeout and mutateTimeout constants, with a comment documenting the rationale. Closes floatpane#985.
floatpanebot
previously requested changes
Apr 27, 2026
Member
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @mvanhorn! Please fix the following issues with your PR:
- Title: Is too long (51 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
Member
|
@mvanhorn follow the format, please |
Formatting issues have been resolved. Thank you!
Contributor
Author
|
Cheers for merging this @andrinoff, thanks. Replacing the bare 60s and 30s literals with fetchTimeout and mutateTimeout makes the split self-documenting wherever someone reads handler.go. |
Contributor
Author
|
Appreciate the quick turnaround @andrinoff. Naming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces ad-hoc
60*time.Secondand30*time.Secondliterals indaemon/handler.gowith two named constants and a brief comment documenting the split, exactly as suggested in the issue body.fetchTimeout(was60*time.Second):handleFetchEmails(line 129)handleFetchEmailBody(line 154)handleMarkRead(line 318)mutateTimeout(was30*time.Second):handleDeleteEmails(line 193)handleArchiveEmails(line 216)handleMoveEmails(line 239)handleMarkRead(line 262)handleFetchFolders(line 287)Why?
If the maintainer wants
handleFetchFoldersreclassified tofetchTimeout(which would be a behavior change from 30s to 60s), happy to do that as a follow-up — kept it at the existing value here to keep this purely a refactor.Closes #985.