[FLORA-412] GitHub repo funding information #428
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing information has been implemented. This includes changes to data types, models and more. GitHub/Client.hs, parsing local GitHub access token and providing a way to fetch the Funding filehave been added. Now need to test the runServer call with the updated JobsRunnerEnv constructor.
mau5mat
force-pushed
the
flora-412-github-repo-funding-information
branch
from
543456b to
9681a53
Compare
tchoutri
reviewed
Sep 14, 2023
Comment on lines
+203
to
+204
| case mGithubToken of | ||
| Nothing -> pure () |
There was a problem hiding this comment.
In retrospect we should also perform such a check in fetchMetadataHandler so that we don't queue jobs for nothing in the absence of the GitHub Token
There was a problem hiding this comment.
I will have a look at sorting this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Contributor checklist