[Linter] Linting R Code for Reproducibility Issues #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: initial linter format ideas i dunno * refactor: linting output was a terrible name * refactor: add todo * refactor: add another todo ✨ * refactor: allow using un-built search in linter rules * refactor: type safety for createSearch and processSearchResult * refactor: todo cleanup
* test: basic test setup for the enrichments * refactor: a lot of type wrangling * feat: mappers but the types are broken * feat-fix: our enrichers and mappers test runs! the result is just wrong lol * feat: call target enrichment functionality * refactor: remove documentation enrichment for now
* feat: basic R1 functionality and tests * feat-fix: r1 function overloads
* feat: linter query * refactor: tiny comment fixes * refactor: address comment changes
There was a problem hiding this comment.
Pull Request Overview
This PR enhances linting and search functionality for R code by introducing reproducibility checks and enriched error handling. Key changes include new test cases for linter and enrichment features, updates to search-builder functionality with additional transformation methods, and the integration of linter queries into the query system.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/functionality/search/search-line.test.ts | Added tests for search enrichment including new assertions using assertSearchEnrichment. |
| test/functionality/linter/linter.test.ts | Introduced new linter tests verifying deprecated function handling. |
| test/functionality/_helper/search.ts | Updated assertSearch to support both array and function expectations. |
| test/functionality/_helper/linter.ts | Added a new helper to assert linter results. |
| test/functionality/_helper/label.ts | Extended available test label contexts to include 'linter'. |
| src/search/search-executor/search-transformer.ts | Added new transformer functions getWith and getMap to support enrichment and mapping. |
| src/search/search-executor/search-mappers.ts | Introduced a new mapper for enrichment with associated type adjustments. |
| src/search/search-executor/search-enrichers.ts | Added enrichment functionality for call targets and updated the enrichment API. |
| src/search/flowr-search-builder.ts | Enhanced the search builder with new methods (with, map, and get) for applying enrichments. |
| src/queries/query.ts | Integrated linter queries into the overall supported queries. |
| src/queries/catalog/linter-query/* | Added linter query format and executor to support linting in the query subsystem. |
| src/linter/* | Added linter rule definitions and formatting for deprecated functions. |
Comments suppressed due to low confidence (2)
src/search/search-executor/search-mappers.ts:29
- [nitpick] Consider revising the informal language in this comment to a more professional tone, e.g., 'Due to current type-system limitations, both the mapper and args require casting despite their intended compatibility.'
// apparently the type system sucks right now so you have to cast both the mapper and the args to a specific type even though they're made to be compatible
src/search/flowr-search-builder.ts:218
- [nitpick] Replace the informal comment with a professional note, such as 'Due to current type-system constraints, explicit casting is required in this context.'
// type system is trash, see search-mappers.ts map function
* wip: basic framework for the query-to-search api * wip: more generic name for the flatten function for queries * feat: searches from queries * feat: retain access to original queries when using fromQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.