out_opentelemetry: fix memory leak by explicitly consuming response body #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
fix-leak
branch
2 times, most recently
from
c2063ea to
434df8f
Compare
Previously, the HTTP output handler did not explicitly read the response body from Excon requests. This caused Excon to retain data in the socket buffer, leading to memory leaks. Furthermore, this unconsumed data caused delays in sending subsequent requests (IO blocking). As a result, the output throughput dropped, causing the Fluentd buffer (MemoryChunk) to gradually bloat as it accumulated pending records. This commit adds `response.body` to force the buffer to be flushed, resolving both the Excon memory leak and the buffer bloat issue.
Collaborator
Author
Before
After
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the HTTP output handler did not explicitly read the response body from Excon requests.
This caused Excon to retain data in the socket buffer, leading to memory leaks.
Furthermore, this unconsumed data caused delays in sending subsequent requests (IO blocking).
As a result, the output throughput dropped, causing the Fluentd buffer (MemoryChunk) to gradually bloat as it accumulated pending records.
This commit adds
response.bodyto force the buffer to be flushed, resolving both the Excon memory leak and the buffer bloat issue.