Merge pull request #43 from reevoo/close-journal-on-rotate

Close Journal explictly on rotate
fluent-plugins-nursery · Oct 3, 2017 · dbd7359 · dbd7359
2 parents f30e587 + 785a804
commit dbd7359
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/fluent-plugin-systemd.gemspec b/fluent-plugin-systemd.gemspec
@@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "reevoocop"
 
   spec.add_runtime_dependency "fluentd", [">= 0.14.11", "< 2"]
-  spec.add_runtime_dependency "systemd-journal", "~> 1.2"
+  spec.add_runtime_dependency "systemd-journal", "~> 1.3"
 end
diff --git a/lib/fluent/plugin/in_systemd.rb b/lib/fluent/plugin/in_systemd.rb
@@ -61,6 +61,8 @@ def shutdown
       private
 
       def init_journal
+        # TODO: ruby 2.3
+        @journal.close if @journal # rubocop:disable Style/SafeNavigation
         @journal = Systemd::Journal.new(path: @path)
         # make sure initial call to wait doesn't return :invalidate
         # see https://github.com/ledbettj/systemd-journal/issues/70