-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter_logs_to_metrics: document field_value usage for counters #1584
base: master
Are you sure you want to change the base?
Conversation
This documents a feature added with this PR: fluent/fluent-bit#10055 Signed-off-by: Fabian Ruff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @databus23, thanks for submitting a docs PR! I just suggested a few edits for clarity and consistency.
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Fabian Ruff <[email protected]>
@alexakreizinger thanks for the feedback. I merged in all your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you :) I'm approving this, but I won't merge anything since it sounds like we're still waiting on a different code PR—feel free to merge this one when the time comes.
This documents a feature added with this PR: fluent/fluent-bit#10055