Skip to content

stream-processing: getting-started: fluent-bit-sql: general cleanup #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexakreizinger
Copy link
Member

@alexakreizinger alexakreizinger commented May 1, 2025

cleanups for style, clarity, and consistency.

@alexakreizinger alexakreizinger requested review from a team as code owners May 1, 2025 22:43
Copy link
Contributor

@cnorris-cs cnorris-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left suggestions, but I've added my approval based on that to keep this moving.

@patrick-stephens
Copy link
Contributor

Could we get a quick description added to the PR? I know the title tries to cover it but why did we need a "general cleanup", etc. would be good - some of the changes are a bit bike sheddy so is it following a stylistic convention and that's the reason why? Be good to know so someone doesn't revert or change again after merge.

@alexakreizinger
Copy link
Member Author

hey @patrick-stephens! this PR is part of an ongoing effort to bring the fluent bit docs up to parity with the Google developer style guide + make general edits for clarity, consistency, etc. I'll let the team know to put a bit more info in any future cleanup PRs 🙂

Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: Alexa Kreizinger <[email protected]>
@alexakreizinger alexakreizinger merged commit e486ba5 into master May 8, 2025
5 checks passed
@alexakreizinger alexakreizinger deleted the alexakreizinger/sc-123159/update-stream-processing-getting-started branch May 8, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants