-
Notifications
You must be signed in to change notification settings - Fork 513
stream-processing: getting-started: fluent-bit-sql: general cleanup #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream-processing: getting-started: fluent-bit-sql: general cleanup #1627
Conversation
Signed-off-by: Alexa Kreizinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left suggestions, but I've added my approval based on that to keep this moving.
Could we get a quick description added to the PR? I know the title tries to cover it but why did we need a "general cleanup", etc. would be good - some of the changes are a bit bike sheddy so is it following a stylistic convention and that's the reason why? Be good to know so someone doesn't revert or change again after merge. |
hey @patrick-stephens! this PR is part of an ongoing effort to bring the fluent bit docs up to parity with the Google developer style guide + make general edits for clarity, consistency, etc. I'll let the team know to put a bit more info in any future cleanup PRs 🙂 |
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: Alexa Kreizinger <[email protected]>
cleanups for style, clarity, and consistency.