Skip to content

Vale: remove exclamations, turn test to error, add new error tests to… #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ at the `suggestion` level and won't block merging.

The following tests are at a `error` level and will prevent merging:

- [Emdash](https://github.com/errata-ai/Google/blob/master/Google/EmDash.yml)
- [Endash](https://github.com/errata-ai/Google/blob/master/Google/EmDash.yml)
- [Exclamation](https://github.com/errata-ai/Google/blob/master/Google/Exclamation.yml)
- [NonStandardQuotes](https://github.com/fluent/fluent-bit-docs/blob/master/vale-styles/FluentBit/NonStandardQuotes.yml):
[Use standard quotes](https://developers.google.com/style/quotation-marks#straight-and-curly-quotation-marks).
By default, Google Docs and Microsoft Word turn standard straight quotes into "smart"
Expand Down
2 changes: 1 addition & 1 deletion SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
* [Getting Started](stream-processing/getting-started/README.md)
* [Fluent Bit + SQL](stream-processing/getting-started/fluent-bit-sql.md)
* [Check Keys and NULL values](stream-processing/getting-started/check-keys-null-values.md)
* [Hands On! 101](stream-processing/getting-started/hands-on.md)
* [Hands On 101](stream-processing/getting-started/hands-on.md)

## Fluent Bit for Developers <a href="#development" id="development"></a>

Expand Down
2 changes: 0 additions & 2 deletions pipeline/filters/kubernetes.md
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,6 @@ spec:

The key point is to set `hostNetwork` to `true` and `dnsPolicy` to `ClusterFirstWithHostNet` that fluent bit DaemonSet could call Kubelet locally. Otherwise it could not resolve the dns for kubelet.

Now you are good to use this new feature!

### Verify that the Use\_Kubelet option is working

Basically you should see no difference about your experience for enriching your log files with Kubernetes metadata.
Expand Down
2 changes: 1 addition & 1 deletion vale-styles/FluentBit/Exclamation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ extends: existence
message: "Don't use exclamation points in text."
link: 'https://developers.google.com/style/exclamation-points'
nonword: true
level: suggestion
level: error
tokens:
- '\w!(?:\s|$)'