task_map: added task map scaling #10044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
edsiper
requested changes
Mar 4, 2025
| } | ||
|
|
||
| if (new_task_map == NULL) { | ||
| return -1; |
There was a problem hiding this comment.
fixed in commit 0c3b656
Additionally the destructor now works with partially initialized instances Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
|
Could you please have a check on this PR? @edsiper @patrick-stephens |
patrick-stephens
added
ok-package-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
task_mapmember of the global context structure (struct flb_config) to make its size dynamic, adds a new field namedtask_map_sizeto track its size and ancillary functionsflb_config_task_map_resizeandflb_config_task_map_growto manage its size.With these changes we overcome the 2048 concurrent task limit previously imposed by the static array size.