out_gelf: fix crash after missing short_message key #10102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for an illegal free in the gelf output plugin when it handled a message lacking the short_message key. In `cb_gelf_flush`: if the input doesn't contain the short_message key `flb_msgpack_to_gelf` will fail and return NULL. The variable `s` is not initialized, but still `flb_sds_destroy(s)` is called which may unexpectedly free some arbitrary pointer. Fixed by initializing `s`. Fixes fluent#10086
bpetermannS11
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport this fix for 3.2
Fix for an illegal free in the gelf output plugin when it handled a message lacking the short_message key.
In
cb_gelf_flush: if the input doesn't contain the short_message keyflb_msgpack_to_gelfwill fail and return NULL. The variablesis not initialized, but stillflb_sds_destroy(s)is called which may unexpectedly free some arbitrary pointer.Fixed by initializing
s.Fixes #10086
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.