-
Notifications
You must be signed in to change notification settings - Fork 1.7k
log: increase precision in log's timestamp to nanoseconds #9985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
35af7f3
to
4d0149b
Compare
ping @edsiper |
I feel v4.0 is a reasonable time to make it the default, the risk should be minor. @edsiper How do you feel about it? |
4d0149b
to
2216177
Compare
Thanks @edsiper. Done. |
Just one more comment because this popped in my notifications. Are we going to fix the inconsistency in I think it should be done in this PR in order to ensure that we have the same behavior in all platforms, otherwise the format string which prints If you need help with the patch let me know @lecaros. |
@leonardo-albertovich I recommend triaging that potential issue in a separate PR (so both can make the cut for 4.0.3) |
I think that'd be quite cumbersome because it means this PR which depends on that would have to wait and get rebased. Is there a specific reason to do so? |
moving to next milestone due to code conflict and resolution |
501200e
to
c34de5a
Compare
Signed-off-by: lecaros <[email protected]>
8b1d3db
to
2198c3b
Compare
code conflict resolved. @edsiper |
Adds nanoseconds precision to the logs Fluent Bit writes.
It's possible in some cases that the underlying implementation of the time functions won't provide nanoseconds precision. In those cases, the precision will be to microseconds, which is still better than to the second. (see here)
Addresses #9983
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.