out_http: Allow disabling http 2xx logs #9987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stewart Webb <[email protected]>
…ccesses In a busy system with lots of different tags/chunks being handled, this can get really noisy in usual operation Signed-off-by: Stewart Webb <[email protected]>
nuclearpidgeon
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to disable log messages for HTTP 2xx responses
As a point of comparison, Fluent Forward egress doesn't log every time it egresses something - but in a busy system using http outputs, fluentbit ends up logging a huge amount because of this 2xx log line during normal operation.
The default has been set such that the logging is still on by default, which should make this a backwards-compatible change.
Testing
Will try update the PR with these things soon:
Documentation
I imagine this will need a docs update. Happy to raise one after getting an initial review on this PR to indicate it's a change you're happy to merge.
Backporting
Can probably afford for this not to be backported unless others really want it
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.