parser: fix unreachable code#4993
Merged
Merged
Conversation
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
approved these changes
Jun 4, 2025
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks!
It is unlikely to affect users, but it would be better to delete the key before the raise just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
The codes written after exeption raised will not be executed.
fluentd/lib/fluent/plugin/parser.rb
Line 69 in 4542929
@map.deleteis definitely executed at above point, so seems changed code might be unnecessary...Docs Changes:
Not needed.
Release Note:
Code refactoring.