in_tail: fix handling of encoding parameter#5010
Merged
Merged
Conversation
Watson1978
force-pushed
the
encoding
branch
4 times, most recently
from
4734262 to
7f0dcb4
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
requested changes
Jun 26, 2025
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
I have added code refactoring.
Could you please check it?
daipom
reviewed
Jun 26, 2025
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Contributor
|
Could you please prepare the release note?
|
Contributor
Author
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4863
What this PR does / why we need it:
If it configures
encodingonly (withoutfrom_encoding), it will convert the string encoding unexpectedly and it might break the string.This PR will fix this behavior and we can handle the string correctly.
As a result, the behavior will be aligned with the documented in https://docs.fluentd.org/input/tail#encoding-from_encoding .
Docs Changes:
Not needed.
Release Note:
in_tail: fixed where specifying only
encodingparameter might cause data corruption (affects since v0.14.12).