Skip to content

warn when backed-up conf file will be included#5240

Merged
Watson1978 merged 1 commit into
fluent:masterfrom
kenhys:warn-duplicated
Feb 2, 2026
Merged

warn when backed-up conf file will be included#5240
Watson1978 merged 1 commit into
fluent:masterfrom
kenhys:warn-duplicated

Conversation

@kenhys

@kenhys kenhys commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

There is a case that unintentionally backed-up
conf file will be loaded by wild card @include.

This commit try to mitigate such a careless mistakes by warning.

Docs Changes:

N/A

Release Note:

N/A

There is a case that unintentionally backed-up
conf file will be loaded by wild card @include.

This commit try to mitigate such a careless mistakes
by warning.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

@Watson1978 Watson1978 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Watson1978 Watson1978 added this to the v1.20.0 milestone Feb 2, 2026
@Watson1978 Watson1978 added the backport to v1.19 We will backport this fix to the LTS branch label Feb 2, 2026
@Watson1978 Watson1978 merged commit 04681a3 into fluent:master Feb 2, 2026
21 checks passed
@kenhys kenhys deleted the warn-duplicated branch February 2, 2026 08:37
github-actions Bot pushed a commit that referenced this pull request Feb 8, 2026
**Which issue(s) this PR fixes**:
Fixes #

**What this PR does / why we need it**:

There is a case that unintentionally backed-up
conf file will be loaded by wild card @include.

This commit try to mitigate such a careless mistakes by warning.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Watson1978 pushed a commit that referenced this pull request Feb 9, 2026
… (#5252)

**Which issue(s) this PR fixes**: 
Backport #5240
Fixes #

**What this PR does / why we need it**: 

There is a case that unintentionally backed-up
conf file will be loaded by wild card @include.

This commit try to mitigate such a careless mistakes by warning.


**Docs Changes**:

N/A

**Release Note**: 

N/A

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kentaro Hayashi <hayashi@clear-code.com>
@Watson1978 Watson1978 added the backported "backport to LTS" is done label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.19 We will backport this fix to the LTS branch backported "backport to LTS" is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants