formatter_out_file: Improve performance by using string interpolation#5281
Merged
Conversation
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
1a06c6b to
0bb431e
Compare
kenhys
approved these changes
Mar 16, 2026
Contributor
|
MEMO: might be useful to detect similar one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Replaced
String#<<with string interpolation (#{}) when building the output line.This avoids unnecessary buffer expansions (reallocations) and significantly improves performance, particularly on Windows.
Micro benchmark
Fluentd benchmark
Run
rake benchmark:run:in_tailwith 10 GB data on Windows.~7% faster by this changing.
Docs Changes:
N/A
Release Note: